Add announce service to Assist Satellite #124927
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hey there @synesthesiam, mind taking a look at this pull request as it has been labeled with an integration ( Code owner commandsCode owners of
|
synesthesiam
force-pushed
the
assist-satellite
branch
from
356af7c to
eedee04
Compare
synesthesiam
force-pushed
the
assist-satellite
branch
from
eedee04 to
99a4942
Compare
synesthesiam
approved these changes
Aug 30, 2024
| pipeline_id = self._resolve_pipeline() | ||
| pipeline = async_get_pipeline(self.hass, pipeline_id) | ||
|
|
||
| tts_options: dict[str, Any] = {} |
There was a problem hiding this comment.
Just a note for future us: we will need to put the correct format here once we have a supported media format coming from the satellite. Otherwise it will always be MP3.
| @@ -54,6 +61,67 @@ def vad_sensitivity_entity_id(self) -> str | None: | |||
| """Entity ID of the VAD sensitivity to use for the next conversation.""" | |||
| return self._attr_vad_sensitivity_entity_id | |||
|
|
|||
| async def async_internal_announce( | |||
There was a problem hiding this comment.
Should we check the supported features here and raise an exception?
There was a problem hiding this comment.
No. That is done by the service call handler. The service is registered in __init__.py with the correct feature flag.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Breaking change
Proposed change
add announce service to Assist Satellite.
Extracted from #124886
Type of change
Additional information
Checklist
ruff format homeassistant tests)If user exposed functionality or configuration variables are added/changed:
If the code communicates with devices, web services, or third-party tools:
Updated and included derived files by running:
python3 -m script.hassfest.requirements_all.txt.Updated by running
python3 -m script.gen_requirements_all.To help with the load of incoming pull requests: