Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix ESPHome and VoIP Assist satellite entity names #126229

Merged
merged 2 commits into from
Sep 26, 2024
Merged

Fix ESPHome and VoIP Assist satellite entity names #126229

merged 2 commits into from
Sep 26, 2024

Conversation

synesthesiam
Copy link
Contributor

@synesthesiam synesthesiam commented Sep 18, 2024 •
edited
Loading

Breaking change

Proposed change

Assist satellite entity names for ESPHome and VoIP previous had "None" in their names. With this change, they will now be called "Assist satellite".

Cleans up the VoIP entity description and strings.json too.

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Deprecation (breaking change to happen in the future)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

  • This PR fixes or closes issue: fixes #
  • This PR is related to issue:
  • Link to documentation pull request:

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • I have followed the perfect PR recommendations
  • The code has been formatted using Ruff (ruff format homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.

To help with the load of incoming pull requests:

@synesthesiam synesthesiam marked this pull request as ready for review September 18, 2024 19:03
@home-assistant
Copy link

Hey there @balloob, mind taking a look at this pull request as it has been labeled with an integration (voip) you are listed as a code owner for? Thanks!

Code owner commands

Code owners of voip can trigger bot actions by commenting:

  • @home-assistant close Closes the pull request.
  • @home-assistant rename Awesome new title Renames the pull request.
  • @home-assistant reopen Reopen the pull request.
  • @home-assistant unassign voip Removes the current integration label and assignees on the pull request, add the integration domain after the command.
  • @home-assistant add-label needs-more-information Add a label (needs-more-information, problem in dependency, problem in custom component) to the pull request.
  • @home-assistant remove-label needs-more-information Remove a label (needs-more-information, problem in dependency, problem in custom component) on the pull request.

@home-assistant
Copy link

Hey there @OttoWinter, @jesserockz, @kbx81, @bdraco, mind taking a look at this pull request as it has been labeled with an integration (esphome) you are listed as a code owner for? Thanks!

Code owner commands

Code owners of esphome can trigger bot actions by commenting:

  • @home-assistant close Closes the pull request.
  • @home-assistant rename Awesome new title Renames the pull request.
  • @home-assistant reopen Reopen the pull request.
  • @home-assistant unassign esphome Removes the current integration label and assignees on the pull request, add the integration domain after the command.
  • @home-assistant add-label needs-more-information Add a label (needs-more-information, problem in dependency, problem in custom component) to the pull request.
  • @home-assistant remove-label needs-more-information Remove a label (needs-more-information, problem in dependency, problem in custom component) on the pull request.

balloob
balloob reviewed Sep 18, 2024
View reviewed changes
homeassistant/components/voip/assist_satellite.py Outdated
Comment on lines 87 to 83
_attr_has_entity_name = True
_attr_name = None
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If it has this, it should just have the device name 🤔 where does None come from.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Mine had a none in the entity id, but not the name. So maybe it got that before I added these attributes.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

On your dev env? Can you try setting up a new entity and if that has the same?

Do you have a device attached to the entity?

@synesthesiam synesthesiam marked this pull request as draft September 19, 2024 19:31
@synesthesiam synesthesiam force-pushed the synesthesiam-20240918-assist-satellite-name branch from 8f6448d to d3c97ee Compare September 26, 2024 15:46
@synesthesiam synesthesiam marked this pull request as ready for review September 26, 2024 15:46
@synesthesiam
Copy link
Contributor Author

Tested again, and this PR fixes the None in both names

@synesthesiam synesthesiam added this to the 2024.10.0 milestone Sep 26, 2024
@frenck frenck merged commit 9db5b48 into dev Sep 26, 2024
31 checks passed
@frenck frenck deleted the synesthesiam-20240918-assist-satellite-name branch September 26, 2024 18:22
frenck pushed a commit that referenced this pull request Sep 26, 2024
@synesthesiam @balloob @frenck
Fix ESPHome and VoIP Assist satellite entity names (#126229)
17e0db9 
Co-authored-by: Paulus Schoutsen <[email protected]>
@github-actions github-actions bot locked and limited conversation to collaborators Sep 27, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@joostlek joostlek joostlek left review comments

@balloob balloob balloob approved these changes

@OttoWinter OttoWinter Awaiting requested review from OttoWinter OttoWinter is a code owner

@jesserockz jesserockz Awaiting requested review from jesserockz jesserockz is a code owner

@bdraco bdraco Awaiting requested review from bdraco bdraco is a code owner

Assignees

@bdraco bdraco

@balloob balloob

@jesserockz jesserockz

@OttoWinter OttoWinter

Labels
bugfix by-code-owner cherry-picked cla-signed integration: esphome integration: voip Quality Scale: internal Quality Scale: platinum small-pr PRs with less than 30 lines.
Projects
None yet
Milestone
2024.10.0
Development

Successfully merging this pull request may close these issues.
7 participants
@synesthesiam @balloob @joostlek @frenck @bdraco @jesserockz @OttoWinter