Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add climate platform to LG ThinQ integration #126241

Open
wants to merge 1 commit into
base: lg_thinq
Choose a base branch
from
Open

Add climate platform to LG ThinQ integration #126241

wants to merge 1 commit into from
+364 −1

Conversation

LG-ThinQ-Integration
Copy link
Contributor

Breaking change

Proposed change

Add climate platform to LG ThinQ integration

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Deprecation (breaking change to happen in the future)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • I have followed the perfect PR recommendations
  • The code has been formatted using Ruff (ruff format homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.

To help with the load of incoming pull requests:

@LG-ThinQ-Integration
Copy link
Contributor Author

LG-ThinQ-Integration commented Sep 19, 2024 •
edited
Loading

I made a mistake when I changed the target branch for the previous climate PR.
So I made a new one.

For your convenience, I added the links for our unresolved reviews. :)

#125663 (comment)
#125663 (comment)

@LG-ThinQ-Integration LG-ThinQ-Integration marked this pull request as ready for review September 19, 2024 04:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
cla-signed integration: lg_thinq new-feature new-platform
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@LG-ThinQ-Integration @JangwonLeeLG