Add text platform to LG ThinQ integration #126245
Open
+129
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
home-assistant
bot
added
cla-signed
integration: lg_thinq
new-feature
new-platform
labels
joostlek
reviewed
Sep 19, 2024
Comment on lines
+27
to
+34
| key=TimerProperty.ABSOLUTE_TO_START, | ||
| translation_key=TimerProperty.ABSOLUTE_TO_START, | ||
| default_hint="Input format 24-hour clock", | ||
| ) | ||
| TIMER_ABSOLUTE_TO_STOP_TEXT_DESC = ThinQTextEntityDescription( | ||
| key=TimerProperty.ABSOLUTE_TO_STOP, | ||
| translation_key=TimerProperty.ABSOLUTE_TO_STOP, | ||
| default_hint="Input format 24-hour clock", |
There was a problem hiding this comment.
So what do we put in here? What's possible?
There was a problem hiding this comment.
It is the absolute time (ex. 00:00 ~ 23:59)
The reason we didn't use 'time' entity is that we can't cancel with 'None'
There was a problem hiding this comment.
I am also wondering if time entities have you to deal with timezones. I think I'll discuss this with others since I don't think a text entity is a right way to display this (its too free form), you'll hear from me
8 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Breaking change
Proposed change
Add text platform to LG ThinQ integration
Type of change
Additional information
Checklist
ruff format homeassistant tests)If user exposed functionality or configuration variables are added/changed:
If the code communicates with devices, web services, or third-party tools:
Updated and included derived files by running:
python3 -m script.hassfest.requirements_all.txt.Updated by running
python3 -m script.gen_requirements_all.To help with the load of incoming pull requests: