Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor smlight event_function to common function #126260

Merged
merged 1 commit into from
Sep 20, 2024

Conversation

tl-sl
Copy link
Contributor

@tl-sl tl-sl commented Sep 19, 2024

Breaking change

Proposed change

This function is used to extract event callbacks from the mock call_arg_lists, it is used in tests for a few different platforms.

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Deprecation (breaking change to happen in the future)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

  • This PR fixes or closes issue: fixes #
  • This PR is related to issue:
  • Link to documentation pull request:

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • I have followed the perfect PR recommendations
  • The code has been formatted using Ruff (ruff format homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.

To help with the load of incoming pull requests:

@MartinHjelmare MartinHjelmare changed the title refactor event_function to common function Refactor event_function to common function Sep 19, 2024
@MartinHjelmare MartinHjelmare changed the title Refactor event_function to common function Refactor smlight event_function to common function Sep 19, 2024
tests/components/smlight/conftest.py Outdated Show resolved Hide resolved
@home-assistant
Copy link

Please take a look at the requested changes, and use the Ready for review button when you are done, thanks 👍

Learn more about our pull request process.

@home-assistant home-assistant bot marked this pull request as draft September 20, 2024 10:05
@tl-sl tl-sl marked this pull request as ready for review September 20, 2024 10:21
@joostlek joostlek merged commit 76967e8 into home-assistant:dev Sep 20, 2024
30 checks passed
sarog pushed a commit to sarog/hass-core that referenced this pull request Sep 20, 2024
JakeMartin-ICL pushed a commit to JakeMartin-ICL/home-assistant that referenced this pull request Sep 21, 2024
@github-actions github-actions bot locked and limited conversation to collaborators Sep 21, 2024
@tl-sl tl-sl deleted the event-function branch September 23, 2024 00:59
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants