Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Matter climate platform attributes when dedicated OnOff attribute is off #126286

Merged
merged 1 commit into from
Sep 23, 2024

Conversation

marcelveldt
Copy link
Member

@marcelveldt marcelveldt commented Sep 19, 2024

Proposed change

Fix a small oversight/edgecase in the Matter climate platform code that parses the state attribute from the the node state.
When a climate device has a dedicated Power switch and that turned off at startup, none of the mandatory attributes are parsed. This PR fixes it and will only override the hvac_mode and hvac_action if that is the case but still parse the temperature attributes

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Deprecation (breaking change to happen in the future)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • I have followed the perfect PR recommendations
  • The code has been formatted using Ruff (ruff format homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.

To help with the load of incoming pull requests:

@home-assistant
Copy link

Hey there @home-assistant/matter, mind taking a look at this pull request as it has been labeled with an integration (matter) you are listed as a code owner for? Thanks!

Code owner commands

Code owners of matter can trigger bot actions by commenting:

  • @home-assistant close Closes the pull request.
  • @home-assistant rename Awesome new title Renames the pull request.
  • @home-assistant reopen Reopen the pull request.
  • @home-assistant unassign matter Removes the current integration label and assignees on the pull request, add the integration domain after the command.
  • @home-assistant add-label needs-more-information Add a label (needs-more-information, problem in dependency, problem in custom component) to the pull request.
  • @home-assistant remove-label needs-more-information Remove a label (needs-more-information, problem in dependency, problem in custom component) on the pull request.

@marcelveldt marcelveldt added this to the 2024.9.3 milestone Sep 19, 2024
@mkkm2112
Copy link

I am very much of a noob @marcelveldt - can you pls tell me what this means? Does this mean there a quick update coming for the Matter integration which will address the unavailable state on my thermostats?

@frenck frenck merged commit 16221cf into dev Sep 23, 2024
31 checks passed
@frenck frenck deleted the matter-climate-fix branch September 23, 2024 07:27
Lektrico pushed a commit to Lektrico/core that referenced this pull request Sep 23, 2024
@frenck frenck mentioned this pull request Sep 23, 2024
@github-actions github-actions bot locked and limited conversation to collaborators Sep 24, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
3 participants