Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update devcontainer to Python 3.13 #132313

Merged
merged 1 commit into from
Dec 13, 2024
Merged

Conversation

cdce8p
Copy link
Member

@cdce8p cdce8p commented Dec 4, 2024

Proposed change

The base image for Python 3.13 is now finally available.
https://github.com/devcontainers/images/releases/tag/v0.4.9
https://mcr.microsoft.com/v2/devcontainers/python/tags/list

This reverts

/CC @silamon

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Deprecation (breaking change to happen in the future)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

  • This PR fixes or closes issue: fixes #
  • This PR is related to issue:
  • Link to documentation pull request:

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • I have followed the perfect PR recommendations
  • The code has been formatted using Ruff (ruff format homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.

To help with the load of incoming pull requests:

@home-assistant home-assistant bot added cla-signed dependency small-pr PRs with less than 30 lines. labels Dec 4, 2024
@cdce8p cdce8p marked this pull request as draft December 4, 2024 23:36
@cdce8p
Copy link
Member Author

cdce8p commented Dec 4, 2024

Maybe not yet? It's still missing from the tag list. Will check again tomorrow.
https://mcr.microsoft.com/v2/devcontainers/python/tags/list

devcontainers/images#1243

@silamon
Copy link
Contributor

silamon commented Dec 5, 2024

Nope they pinned the release from the wrong commit if I look fast. I don't expect them this week, looking how slow it nowadays goes in that repository.

@silamon
Copy link
Contributor

silamon commented Dec 5, 2024

Code change looks good, so good to go when the devcontainer is available.

@silamon
Copy link
Contributor

silamon commented Dec 9, 2024

devcontainers/images#1250

@cdce8p cdce8p marked this pull request as ready for review December 13, 2024 00:45
@cdce8p
Copy link
Member Author

cdce8p commented Dec 13, 2024

Nope they pinned the release from the wrong commit if I look fast. I don't expect them this week, looking how slow it nowadays goes in that repository.

Seems they finally got it together. The tag is up on https://mcr.microsoft.com/v2/devcontainers/python/tags/list
With that we can merge this now.

@cdce8p cdce8p added the smash Indicator this PR is close to finish for merging or closing label Dec 13, 2024
Copy link
Member

@frenck frenck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

Thanks, @cdce8p 👍

../Frenck

@frenck frenck merged commit e4cca3f into home-assistant:dev Dec 13, 2024
64 checks passed
@cdce8p cdce8p deleted the devcontainer-313 branch December 13, 2024 08:52
@github-actions github-actions bot locked and limited conversation to collaborators Dec 14, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
cla-signed dependency small-pr PRs with less than 30 lines. smash Indicator this PR is close to finish for merging or closing
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants