-
-
Notifications
You must be signed in to change notification settings - Fork 7.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add mention of igloodeveloper API #36870
base: next
Are you sure you want to change the base?
Conversation
✅ Deploy Preview for home-assistant-docs ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
📝 WalkthroughWalkthroughThe pull request introduces minor modifications to the Igloohome integration documentation. The changes primarily involve clarifying the method of accessing paired smart access devices by explicitly mentioning the "igloodeveloper API" and streamlining the troubleshooting section related to API credentials. The documentation update aims to provide more precise information about the integration's functionality and potential troubleshooting steps. Changes
The changes are documentation-related and do not impact the functional implementation of the Igloohome integration. Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
🧹 Nitpick comments (1)
source/_integrations/igloohome.markdown (1)
17-17
: Fix grammar in the features introduction.There's a subject-verb agreement error in the sentence.
-The features of this integration includes: +The features of this integration include:🧰 Tools
🪛 LanguageTool
[grammar] ~17-~17: Possible subject-verb agreement error.
Context: ...r API. The features of this integration includes: - For [Bridge](https://www.igloohome....(NNS_OF_SINGULAR_AGREEMENT)
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (1)
source/_integrations/igloohome.markdown
(2 hunks)
🧰 Additional context used
🪛 LanguageTool
source/_integrations/igloohome.markdown
[grammar] ~17-~17: Possible subject-verb agreement error.
Context: ...r API. The features of this integration includes: - For [Bridge](https://www.igloohome....
(NNS_OF_SINGULAR_AGREEMENT)
⏰ Context from checks skipped due to timeout of 90000ms (3)
- GitHub Check: Redirect rules - home-assistant-docs
- GitHub Check: Header rules - home-assistant-docs
- GitHub Check: Pages changed - home-assistant-docs
🔇 Additional comments (1)
source/_integrations/igloohome.markdown (1)
17-17
: LGTM! Good clarification about the API.Adding explicit mention of the igloodeveloper API improves clarity about how the integration interfaces with the devices.
🧰 Tools
🪛 LanguageTool
[grammar] ~17-~17: Possible subject-verb agreement error.
Context: ...r API. The features of this integration includes: - For [Bridge](https://www.igloohome....(NNS_OF_SINGULAR_AGREEMENT)
@@ -14,7 +14,7 @@ ha_platforms: | |||
ha_integration_type: device | |||
--- | |||
|
|||
The **igloohome** {% term integration %} grants Home Assistant access to paired [smart access device\(s\)](https://www.igloohome.co/#products). The features of this integration includes: | |||
The **igloohome** {% term integration %} grants Home Assistant access to paired [smart access device\(s\)](https://www.igloohome.co/#products) via the igloodeveloper API. The features of this integration includes: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
How is that of need for end users?
As a user it doesn't matter?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You can read more about why it should be added in the pr description.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If we don't want to have it added, then let's close this one. I was also about to have it not mentioned during review, but the comment from the code owner made sense to me.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You can read more about why it should be added in the pr description.
There is nothing there, besides a link to a comment that doesn't highlight "why".
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please take a look at the requested changes, and use the Ready for review button when you are done, thanks 👍 |
Proposed change
#35784 (comment)
Type of change
current
branch).current
branch).next
branch).next
branch).Additional information
Checklist
current
branch.next
branch.Summary by CodeRabbit