Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add business days utils #12

Merged
merged 3 commits into from
Mar 15, 2024
Merged

Conversation

khalidwilliams
Copy link
Contributor

@khalidwilliams khalidwilliams commented Mar 15, 2024

[Hack Day] Add a series of functions for working with business days, previously kept in the homebound-team/date-fns repo. The aim is to eventually remove this fork / its patches from other Homebound repos.

@khalidwilliams khalidwilliams requested review from zgavin, blambillotte and a team March 15, 2024 20:48
@khalidwilliams khalidwilliams changed the title Feat/add business days utils feat: add business days utils Mar 15, 2024
Copy link
Contributor

@zgavin zgavin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lazy ask, are these just copy/pasted from the previous patch?

@khalidwilliams
Copy link
Contributor Author

@zgavin yep, with the tests moved over from mocha to jest

@khalidwilliams khalidwilliams merged commit 7137808 into main Mar 15, 2024
3 of 5 checks passed
@khalidwilliams khalidwilliams deleted the feat/add-business-days-utils branch March 15, 2024 20:57
@homebound-team-bot
Copy link

🎉 This PR is included in version 1.7.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

@stephenh
Copy link
Contributor

@khalidwilliams / @blambillotte I suppose this is somewhat comical at this point (where we put these functions :-)), but personally I would not have added them to activesupport, as I generally see activesupport as "something anyone (non-HB-even) could drop into their project and get ergonomic DX for javascript's core arrays/etc data structures".

These are basically "our custom date-fns" and imo should be in a standalone @homebound/date-fn-utils or @homebound/business-days repo.

For awhile, we had ~good infra to setup in ts libraries + repositories, i.e. see the rtl-utils & friends repos that are ~handful-of-line repos that have semver auto-publish to npm/CI/etc. setup. It's not too much work.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants