-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(array): unanimous #5
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nice 👍
@zgavin kinda surprised you 👍 :-) I was going to soft -1 b/c I was thinking we'd stay within the real of "mainstream as-in methods that have shown up in other collection libraries", i.e. the Ruby & Scala collections being the "most ergonomic" in terms of helper methods. I.e. we've taken I personally haven't seen a But 🤷 you're thinking why not? (Now I'm curious to check Scala to see if they have something like this...) |
@stephenh I think we've added some novel things things purely to suite our needs already, so I'm good with adding it. For approvals this is a pattern that's come up a couple times. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
+1 with the caveat I 8.5-out-of-10 prefer the name everyHasSame
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
🎉 This PR is included in version 1.3.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
I've been writing several checks of the form...
lately and I'd like it to just be built-in.