Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add avahi file advertiser #1023

Draft
wants to merge 2 commits into
base: latest
Choose a base branch
from
Draft

Conversation

jneubrand
Copy link

@jneubrand jneubrand commented Feb 11, 2024

♻️ Current situation

  • the docker container requires host networking because homebridge wants to advertise its own service

💡 Proposed solution

  • make it possible to publish zeroconf information via an avahi xml file, so that it can be mounted, example:
    volumes:
    - /etc/avahi/services/myhub-0000.service:/homebridge/myhub-0000.service
    (of course, this also requires changes in config.json as well as jneubrand/homebridge#94b2f53)
    once this is done, it's no longer necessary to expose host networking when using the docker homebridge image. (other relevant ports need to be exposed explicitly nonetheless)

⚙️ Release Notes

  • add avahi-file advertiser

➕ Additional Information

  • i've been using this patch for a few years and it works
  • should probably allow users to configure the path the .service file is written to

Testing

  • none implemented, just want to submit a proof-of-concept pr to check if anyone else wants this :)

Reviewer Nudging

this isn't ready to merge yet

@jneubrand
Copy link
Author

Dear maintainers: do you have opinions on how the path for .service files should be configured/passed in? I saw createWithOptions for BonjourHAPAdvertiser as well as the responderOptions parameter for CiaoAdvertiser, but those never seem to be called from homebridge/homebridge itself.

@jneubrand jneubrand marked this pull request as draft February 20, 2024 22:56
@Supereg
Copy link
Member

Supereg commented Feb 26, 2024

Hey,
Thank you for this contribution. This looks great and very promising for more isolated docker-based installations of Homebridge.
It will probably take some more time until we can have a more closer look at this. We hope to be back around end of March 👍

@NorthernMan54
Copy link
Contributor

@jneubrand the GitHub repo docker-homebridge is where the docker image is built from, including the scripts etc. Would it make sense to open this there?

PS - I’m out of the country till mid March so can’t look at this till then.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants