Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update to use standard GAE images #91

Merged
merged 4 commits into from
Oct 2, 2019

Conversation

wrmilling
Copy link
Member

Also updates to a new GAE service account

What was the feature/problem?

Fix deployments so that they will work from the release branch. This also moves the decryption to happen only on a before_deploy step. Hard to test without attempting a deploy from release branch but should help with issues like #70.

How does this PR address the above feature/problem?

  • Move deployments to standard images for GAE.
  • Add new service account key encrypted.

Check lists

  • Test passed (Configuration Change)
  • Coding style (indentation, etc)

Additional Comments (if any)

@codecov-io
Copy link

codecov-io commented Oct 2, 2019

Codecov Report

Merging #91 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master      #91   +/-   ##
=======================================
  Coverage   95.39%   95.39%           
=======================================
  Files          28       28           
  Lines         391      391           
  Branches       36       36           
=======================================
  Hits          373      373           
  Misses         15       15           
  Partials        3        3
Flag Coverage Δ
#api 97.12% <ø> (ø) ⬆️
#ui 94% <ø> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 749fade...72880d3. Read the comment docs.

@wrmilling wrmilling force-pushed the update-automated-deploy-for-gae branch from cf1c098 to ea5617f Compare October 2, 2019 15:29
Also updates to a new GAE service account
@wrmilling wrmilling force-pushed the update-automated-deploy-for-gae branch from ea5617f to c058d40 Compare October 2, 2019 15:30
Copy link
Collaborator

@crstamps2 crstamps2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@crstamps2 crstamps2 merged commit a959fa1 into master Oct 2, 2019
@wrmilling wrmilling deleted the update-automated-deploy-for-gae branch October 3, 2019 13:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants