showImages: Fix audio being played in the background #5521
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
larsjohnsen
changed the title
|
@larsjohnsen are you able to lint? |
larsjohnsen
force-pushed
the
showimages-audio-background-fix
branch
from
6092eaa
to
0d1fdbf
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It seems like the issue resolved in #5512 did more than just improving performance. In some cases it also prevented Reddit's video player from being initialized in the background, causing audio being played.
This PR reworks the reverted code by caching the setting value in localStorage and thereby letting us avoid having the
undologic (which is incompatible with manifest V3).Relevant issue: Fixes #5519
Tested in browser: Chrome 124