environment/permissions: Fix permission popup not showing #5538
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`window.screen` is not available in manifest v3, causing the prompt window fallback method to fail.
larsjohnsen
force-pushed
the
permissions-window-workaround
branch
from
85e6056
to
d3fc80e
Compare
|
lmk if good to merge and will do a release this weekend. |
Should be good to go! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
window.screenis not available in manifest v3, causing the prompt window fallback method to fail. This uses the web extension API to find the coordinates to place the popup.The fallback method is ordinarily not needed in Chrome, but other extensions may interfere (see #5531) Chrome's detection of user initiated permission requests.
Relevant issue: #5531
Tested in browser: Firefox 130, Chrome 128