Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

perf: speed up adding fields, reduce memalloc if field name is already prefixed with "app." #406

Merged
merged 6 commits into from
Nov 30, 2023

Commits on Nov 28, 2023

  1. fix: reduce memalloc if field names pre-prefixed

    There is a remarkable amount of memory allocation occurring under load
    to perform the field name "app." prefixing by the Beeline with "app.".
    This change skips the memory allocations needed for string concat and
    usage if the "app." prefix is already present on the field name
    provided.
    robbkidd committed Nov 28, 2023
    Configuration menu
    Copy the full SHA
    bd740f4 View commit details
    Browse the repository at this point in the history

Commits on Nov 30, 2023

  1. bring back local variable

    We have concluded that calling functions as parameters to functions is
    not as easy to read as local variable assignment and using the variable
    as the parameter. Benchmarking indicates that there is no difference in
    allocations between assigning a local variable in AddField() and having
    a function return a value that is immediately used as a parameter still
    within the scope of AddField().
    robbkidd committed Nov 30, 2023
    Configuration menu
    Copy the full SHA
    d6e194b View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    83f244b View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    1dce8ed View commit details
    Browse the repository at this point in the history
  4. more better

    robbkidd committed Nov 30, 2023
    Configuration menu
    Copy the full SHA
    99445fc View commit details
    Browse the repository at this point in the history
  5. update doc comments about error value handling

    Co-authored-by: JamieDanielson <[email protected]>
    robbkidd and JamieDanielson committed Nov 30, 2023
    Configuration menu
    Copy the full SHA
    f93e3c0 View commit details
    Browse the repository at this point in the history