Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

maint: Tidy up smoke test docker file #384

Merged
merged 1 commit into from
May 9, 2024
Merged

Conversation

MikeGoldsmith
Copy link
Contributor

Which problem is this PR solving?

Cleans up the docker file used for smoke tests.

Short description of the changes

  • remove unused app-aspnetcore section
  • move default HONEYCOMB_API_ENDPOINT to sdk-grpc

@MikeGoldsmith MikeGoldsmith added type: maintenance The necessary chores to keep the dust off. version: no bump A PR with maintenance or doc changes that aren't included in a release. labels May 9, 2024
@MikeGoldsmith MikeGoldsmith self-assigned this May 9, 2024
@MikeGoldsmith MikeGoldsmith requested a review from a team as a code owner May 9, 2024 14:09
@MikeGoldsmith MikeGoldsmith merged commit 5c53b5d into main May 9, 2024
4 checks passed
@MikeGoldsmith MikeGoldsmith deleted the mike/docker-clean-up branch May 9, 2024 14:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: maintenance The necessary chores to keep the dust off. version: no bump A PR with maintenance or doc changes that aren't included in a release.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants