Skip to content

Commit

Permalink
maint: update submodule to use HNY fork (#1)
Browse files Browse the repository at this point in the history
* maint: update submodule to use fork

* go mod tidy

* update submodule to latest proto definitions

* generate go files from updated proto definitions

* run generate on an amd machine

* use the latest build tool

* don't change the otlp module name

* remove unecessary import in go.mod

* make sure make protobuf doesn't change the module name for otlp

* try again

---------

Co-authored-by: Yingrong Zhao <[email protected]>
Co-authored-by: Yingrong Zhao <[email protected]>
  • Loading branch information
3 people authored Jul 1, 2024
1 parent 00414dc commit a9bd1b3
Show file tree
Hide file tree
Showing 20 changed files with 2,816 additions and 1,661 deletions.
4 changes: 2 additions & 2 deletions .gitmodules
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
[submodule "opentelemetry-proto"]
path = opentelemetry-proto
url = https://github.com/open-telemetry/opentelemetry-proto
branch = v0.19.0
url = https://github.com/honeycombio/opentelemetry-proto
branch = main
4 changes: 2 additions & 2 deletions Makefile
Original file line number Diff line number Diff line change
Expand Up @@ -41,7 +41,7 @@ PROTOBUF_GEN_DIR := opentelemetry-proto-gen
PROTOBUF_TEMP_DIR := $(GEN_TEMP_DIR)/go
PROTO_SOURCE_DIR := $(GEN_TEMP_DIR)/proto
SOURCE_PROTO_FILES := $(subst $(OTEL_PROTO_SUBMODULE),$(PROTO_SOURCE_DIR),$(SUBMODULE_PROTO_FILES))
GO_MOD_ROOT := go.opentelemetry.io/proto
GO_MOD_ROOT := github.com/honeycombio/opentelemetry-proto-go
OTLP_OUTPUT_DIR := otlp
GO_VERSION := 1.17

Expand All @@ -53,7 +53,7 @@ $(1)

endef

OTEL_DOCKER_PROTOBUF ?= otel/build-protobuf:0.11.0
OTEL_DOCKER_PROTOBUF ?= otel/build-protobuf:0.24.0
PROTOC := docker run --rm -u ${shell id -u} -v${PWD}:${PWD} -w${PWD} ${OTEL_DOCKER_PROTOBUF} --proto_path="$(PROTO_SOURCE_DIR)"

.DEFAULT_GOAL := protobuf
Expand Down
1,070 changes: 0 additions & 1,070 deletions go.sum

Large diffs are not rendered by default.

2 changes: 1 addition & 1 deletion otlp/collector/logs/v1/logs_service.pb.go

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

24 changes: 14 additions & 10 deletions otlp/collector/logs/v1/logs_service.pb.gw.go

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion otlp/collector/logs/v1/logs_service_grpc.pb.go

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion otlp/collector/metrics/v1/metrics_service.pb.go

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

24 changes: 14 additions & 10 deletions otlp/collector/metrics/v1/metrics_service.pb.gw.go

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion otlp/collector/metrics/v1/metrics_service_grpc.pb.go

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion otlp/collector/trace/v1/trace_service.pb.go

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

26 changes: 15 additions & 11 deletions otlp/collector/trace/v1/trace_service.pb.gw.go

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion otlp/collector/trace/v1/trace_service_grpc.pb.go

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

9 changes: 6 additions & 3 deletions otlp/common/v1/common.pb.go

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

18 changes: 9 additions & 9 deletions otlp/go.mod
Original file line number Diff line number Diff line change
Expand Up @@ -3,16 +3,16 @@ module github.com/honeycombio/opentelemetry-proto-go/otlp
go 1.17

require (
github.com/grpc-ecosystem/grpc-gateway/v2 v2.11.2
go.opentelemetry.io/proto/otlp v0.19.0
google.golang.org/grpc v1.48.0
google.golang.org/protobuf v1.28.1
github.com/grpc-ecosystem/grpc-gateway/v2 v2.20.0
go.opentelemetry.io/proto/otlp v1.3.1
google.golang.org/grpc v1.64.0
google.golang.org/protobuf v1.34.2
)

require (
github.com/golang/protobuf v1.5.2 // indirect
golang.org/x/net v0.0.0-20220624214902-1bab6f366d9e // indirect
golang.org/x/sys v0.0.0-20220610221304-9f5ed59c137d // indirect
golang.org/x/text v0.3.7 // indirect
google.golang.org/genproto v0.0.0-20220805133916-01dd62135a58 // indirect
golang.org/x/net v0.23.0 // indirect
golang.org/x/sys v0.18.0 // indirect
golang.org/x/text v0.15.0 // indirect
google.golang.org/genproto/googleapis/api v0.0.0-20240513163218-0867130af1f8 // indirect
google.golang.org/genproto/googleapis/rpc v0.0.0-20240513163218-0867130af1f8 // indirect
)
Loading

0 comments on commit a9bd1b3

Please sign in to comment.