feat: extract decision span from full span #1338
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MikeGoldsmith
requested changes
Sep 18, 2024
MikeGoldsmith
approved these changes
Sep 30, 2024
TylerHelmuth
pushed a commit
that referenced
this pull request
Oct 16, 2024
Extract only necessary information that's needed for trace decision from a full span so that we can forward only the key fields to peers later part of #1318 - add a method on `Span` to extract only necessary information into a new types.Event - add a method to differentiate a full span from a decision span - store `IsRoot` information on `Span` - simplify naming for span annotation types
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which problem is this PR solving?
Extract only necessary information that's needed for trace decision from a full span so that we can forward only the key fields to peers later
part of #1318
Short description of the changes
Spanto extract only necessary information into a new types.EventIsRootinformation onSpan