fix: incorrect conversion between integer types (#500)

Issue flagged by CodeQL. - Closes #499
honeycombio · Jul 17, 2024 · 3ecd18f · 3ecd18f
1 parent b9814af
commit 3ecd18f
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 3 deletions.
diff --git a/honeycombio/type_helpers.go b/honeycombio/type_helpers.go
@@ -19,7 +19,7 @@ func coerceValueToType(i string) interface{} {
 
 	// Plugin SDK assumes 64bit so we'll do the same
 	if v, err := strconv.ParseInt(i, 10, 64); err == nil {
-		return int(v)
+		return v
 	} else if v, err := strconv.ParseFloat(i, 64); err == nil {
 		return v
 	} else if v, err := strconv.ParseBool(i); err == nil {

diff --git a/honeycombio/type_helpers_test.go b/honeycombio/type_helpers_test.go
@@ -30,12 +30,12 @@ func Test_coerceValueToType(t *testing.T) {
 		{
 			name:     "int",
 			input:    "300",
-			expected: 300,
+			expected: int64(300),
 		},
 		{
 			name:     "zero",
 			input:    "0",
-			expected: 0,
+			expected: int64(0),
 		},
 		{
 			name:     "stringy number",