Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Dynamic String Prompt for REPL #624

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

khill-fbmc
Copy link
Contributor

I feel this is a pretty naive approach to this. I know that you offer the app.prompt() method so maybe I could use that instead? What are your thoughts?

return Math.floor(Math.random() * (max - min + 1)) + min;
}

const dice = app.add(

Check notice

Code scanning / CodeQL

Unused variable, import, function or class Note

Unused variable dice.
@hongaar
Copy link
Owner

hongaar commented Aug 19, 2024

Thanks for your PR. This looks fine to me. Please also change the signature of the prompt method and update the readme.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants