Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: update quick start section #43

Merged
merged 6 commits into from
May 28, 2024
Merged

docs: update quick start section #43

merged 6 commits into from
May 28, 2024

Conversation

6km
Copy link
Contributor

@6km 6km commented May 28, 2024

  • added Hono logo
  • designed a terminal image the demonstrates create-hono
  • updated create-hono commands
  • and more...

@yusukebe
Copy link
Member

Hi @6km !

Thank you for the PR. It's good. But I think we don't need the HTML section:

https://github.com/honojs/create-hono/pull/43/files#diff-b335630551682c19a781afebcf4d07bf978fb1f8ac04c6bf87428ed5106870f5R1-R17

The reasons:

  • This is just a project repository to develop the create-hono. Actually, it's not for the end-user. We don't have to appeal it in this repo flashy.
  • It's a little thing; we have to maintain it. For example, we will have to change the screenshot if the menu will be changed.

So, I'd like to remove the section. Leaving Quick Start is good because it may not be changed.

@6km
Copy link
Contributor Author

6km commented May 28, 2024

@yusukebe I got it! You're right create-hono is subject to change by time, it's gonna be difficult to change it by every new update.
I will remove it.

@6km 6km changed the title docs: add Hono logo, showcase image, and text changes docs: update quick start section May 28, 2024
@yusukebe
Copy link
Member

@6km Thank you for understanding. Looks good! Merging now.

@yusukebe yusukebe merged commit a490d84 into honojs:main May 28, 2024
2 checks passed
@6km 6km deleted the readme-update branch May 28, 2024 17:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants