Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: don't minify binary file #53

Merged
merged 1 commit into from
Jun 27, 2024

Conversation

ryuapp
Copy link
Contributor

@ryuapp ryuapp commented Jun 27, 2024

In #49, it changed to building with minifier, but as a result debugging became difficult.
It is better not to minify due to reports from users.

image

@yusukebe
Copy link
Member

@ryuapp

Ahh, indeed. It's important to see what happened easily.

@goisaki You did well. But I'll merge this.

Thanks!

@yusukebe yusukebe merged commit 35ee921 into honojs:main Jun 27, 2024
2 checks passed
@ryuapp ryuapp deleted the dont-minify-binary-file branch June 27, 2024 23:06
@goisaki goisaki mentioned this pull request Aug 19, 2024
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants