fix(dev-server): set navigator.userAgent correctly (#156)

* fix(dev-server): set `navigator.userAgent` with `Object.defineProperty` * add changeset * works on Node.js 20.x * fixed the changeset
honojs · Jul 12, 2024 · e62bf1b · e62bf1b
1 parent d833ce9
commit e62bf1b
Show file tree

Hide file tree

Showing 2 changed files with 16 additions and 4 deletions.
diff --git a/.changeset/quick-lies-pull.md b/.changeset/quick-lies-pull.md
@@ -0,0 +1,5 @@
+---
+'@hono/vite-dev-server': patch
+---
+
+fix: set `navigator.userAgent` correctly
diff --git a/packages/dev-server/src/adapter/cloudflare.ts b/packages/dev-server/src/adapter/cloudflare.ts
@@ -16,11 +16,18 @@ export const cloudflareAdapter: (options?: CloudflareAdapterOptions) => Promise<
   proxy ??= await getPlatformProxy(options?.proxy)
   // Cache API provided by `getPlatformProxy` currently do nothing.
   Object.assign(globalThis, { caches: proxy.caches })
-  Object.assign(globalThis, {
-    navigator: {
+  if (typeof globalThis.navigator === 'undefined') {
+    // @ts-expect-error not typed well
+    globalThis.navigator = {
       userAgent: 'Cloudflare-Workers',
-    },
-  })
+    }
+  } else {
+    Object.defineProperty(globalThis.navigator, 'userAgent', {
+      value: 'Cloudflare-Workers',
+      writable: false,
+    })
+  }
+
   return {
     env: proxy.env,
     executionContext: proxy.ctx,