Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(dev-server) Missing exports for node,bun adapter #170

Merged
merged 2 commits into from
Aug 29, 2024

Conversation

arisris
Copy link
Contributor

@arisris arisris commented Aug 29, 2024

Fix missing export in package.json

In the recent update i have add very initial bun and node.js adapter but i forget to add exports definition in the package.json so the update does not export module correctly.

#166
#167

Copy link

changeset-bot bot commented Aug 29, 2024

🦋 Changeset detected

Latest commit: 4a9b5d0

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@hono/vite-dev-server Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@yusukebe
Copy link
Member

Hi @arisris

I've left a comment.

Copy link
Member

@yusukebe yusukebe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@yusukebe
Copy link
Member

@arisris

Thank you! Merge now.

@yusukebe yusukebe merged commit 4137d3f into honojs:main Aug 29, 2024
3 checks passed
@github-actions github-actions bot mentioned this pull request Aug 29, 2024
@arisris arisris deleted the fix-dev-server-missing-export branch August 29, 2024 08:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants