This repository has been archived by the owner on Aug 9, 2023. It is now read-only.
ci: Add clippy + fixing clippy errors #14
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aasseman
force-pushed
the
aasseman/issue5
branch
from
4ae9abe
to
4f1ab5e
Compare
Signed-off-by: Alexis Asseman <[email protected]>
Signed-off-by: Alexis Asseman <[email protected]>
IndexerError already implemented to_string through `impl std::fmt::Display for IndexerError` Signed-off-by: Alexis Asseman <[email protected]>
Signed-off-by: Alexis Asseman <[email protected]>
Also fixes clippy::clone_double_ref Signed-off-by: Alexis Asseman <[email protected]>
Signed-off-by: Alexis Asseman <[email protected]>
aasseman
force-pushed
the
aasseman/issue5
branch
from
4f1ab5e
to
f01c51d
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I added clippy in CI such that it fails on warnings, but ignores dead code (thought it'd be useful for now after looking at #13 ).
I also fixed or silenced clippy errors in a few passes. Reviewing commit by commit should be easier.
Some choices here are opinionated, so feel free to push back on some of the choices here.
Fixes #5