Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Favicon not dark-mode friendly #19

Open
OfficialCRUGG opened this issue Feb 5, 2023 · 0 comments · May be fixed by #20
Open

Favicon not dark-mode friendly #19

OfficialCRUGG opened this issue Feb 5, 2023 · 0 comments · May be fixed by #20

Comments

@OfficialCRUGG
Copy link
Contributor

OfficialCRUGG commented Feb 5, 2023

image
Compared to the other Hop sites, the Favicon of the Docs is not dark-mode friendly, as it uses black-transparent instead of black-white as the color scheme.
I'd suggest using the Favicon that Hop uses in other places for increased consistency.
Otherwise, an SVG Favicon using prefers-color-scheme could also be used to render the favicon as either white or black depending on the browser theme

@OfficialCRUGG OfficialCRUGG linked a pull request Feb 6, 2023 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant