fix: favicon consistency #20
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
also makes the favicon dark-mode friendly
|
It appears Mintlify needs an SVG File for the Favicon. |
|
Hi @OfficialCRUGG, very sorry for the late response on this. If you're still up for it, I've provided the branding kit below. Otherwise this will be fixed soon. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes #19 (Favicon being inconsistent and not dark-mode friendly)
I've removed the
favicon.svg(which even appears to have been created through some bitmap tracing tool for some reason?!) and replaced it withfavicon.icofrom https://hop.io/favicon.icoI've also updated the respective config entry in the
mint.json. Whilst this should work, I was unable to test this change because of some Mintlify Bug, so it would be great if someone could double-check this before it gets merged.Update: ico file does not work. will fix asap