-
-
Notifications
You must be signed in to change notification settings - Fork 20
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Setup server-side abort and error handler hooks for commands #113
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Also fixed a bug with callback setup
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add's hooks to trap and handle Command
aborts
anderrors
.Video Demo
Example
Abort Visibility
Aborts will return an HTTP status of
285
instead of200
along with some HTTP Headers to improve debuggability.Error Visibility
Errors return an HTTP status of
5XX
along with some HTTP Headers to improve debuggability. Error handling works if an error is raised in a Command lifecycle callback (before_command
, etc.) or if raised from within the Command's perform method.HTTP Headers
This PR introduces 2 new HTTP Headers to help with debugging.
TurboBoost-Command
- Name of the Command that was invokedTurboBoost-Command-Status
- Status and info regarding Command invocation