WIP: Fix bug reported by [email protected] #4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When saving an event with existing user attendees, only new attendees are saved but existing attendees are dropped
|
This patch seems to mangle the display of the
|
|
Hi Michael,
Thank you for catching that. I did not have this during my tests. I will check if I am missing anything related from upstream in my environment. I will need to improve on this. Turning the PR to wip. Regards Ralf |
ralflang
changed the title
|
I cannot reproduce this glitch on my fork. Maybe it's because of some other changes I have... |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When saving an event with existing user attendees, only new attendees are saved but existing attendees are dropped.
This is because the prettyautocompleter invokes the parseuser on reset. parseuser will simply assume for a user string which is not in the "Displayname [user]" format that username and displayname are the same.
This in turn breaks two situations: Users sent to saveEvent will be invalid (unless the displayname happens to match the user name) also removing an existing user from the dialog will not remove his freebusy line.
The patch feeds the expected string format for parseuser rather than the bare displayname. The dialog will be loaded properly and all operations work as expected.