ISSUE-1330: Allow jwt or knox sso as underlying authentication for SAM #1331
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Change-Id: I788f12ffb4e0e673d5c6edbfad90e43b9d401a6b
|
@arunmahadevan I have tested this on a cluster and it works fine. Please review. Ideally it will be good to put this in the next maint release and all release going forward. |
| if (principal == null || !httpRequest.getAuthType().equalsIgnoreCase(KERBEROS_AUTH)) { | ||
| // We now also support Knox SSO using jwt as underlying authentication mechanism. Hence added jwt as a valid type | ||
| // Probably jwt does not sound right in this class and we are also passing KERBEROS_AUTH for jwt below where we | ||
| // instantiate a SecurityContext. That is because there are checks down the line for kerberos as well |
There was a problem hiding this comment.
Maybe then this class needs to be renamed to StreamlineAuthenticationRequestFilter and the right authType passed to the StreamlineSecurityContext as well?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change-Id: I788f12ffb4e0e673d5c6edbfad90e43b9d401a6b