Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Local installation instruction and formulations in UI, especially "label". #211

Closed
wants to merge 3 commits into from

Conversation

Ettrig
Copy link
Contributor

@Ettrig Ettrig commented Feb 5, 2024

The word "label" is used here in a very technical sense that is peculiar to CNNs, especially early CNN research. We should try to not burden the users with more implementation details than necessary.

It was my intention to make divide these changes into two different pull requests. But I missed making branches and find it very difficult to add them now.

@kshitijrajsharma
Copy link
Member

kshitijrajsharma commented Feb 6, 2024

@Ettrig What do you recommend how this should be communicated to general user ?

The word "label" is used here in a very technical sense that is peculiar to CNNs, especially early CNN research. We should try to not burden the users with more implementation details than necessary

From your PR I got an understanding you used term : osm features , map features !

@kshitijrajsharma
Copy link
Member

It was my intention to make divide these changes into two different pull requests. But I missed making branches and find it very difficult to add them now.

yes, branching is ideal

@@ -114,9 +114,9 @@ const AOI = (props) => {
return (
<>
<Grid item md={12} className="card" marginBottom={1}>
<Tooltip title="For each AOI, we need to make sure labels inside it are alighed and complete to acheive best model accuracy">
<Tooltip title="For each AOI, we need to ensure that all buildings are mapped and correctly aligned.">
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Currently its building but label might not represent only buildings later stage , I wonder how we can communicate this

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is surprisingly difficult. We cannot say "all map features" because we cannot handle all kinds of map features. Saying "all map features that fAIr can handle" is too complex and subtle. Can we stay with "buildings" and hope it is updated when needed? I think that even if roads and water flows are added, "buildings" is more useful than "labels".

@@ -170,7 +170,7 @@ const AOI = (props) => {
{/* <IconButton aria-label="comments">
<DeleteIcon />
</IconButton> */}
{/* <Tooltip title="Create Labels on RapID Editor">
{/* <Tooltip title="Create map feature in RapID Editor">
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

map features sound good

Copy link
Member

@kshitijrajsharma kshitijrajsharma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yay ! Thanks for this !!! All good from my side !

@Ettrig Ettrig closed this by deleting the head repository Feb 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants