Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added login page #71

Closed
wants to merge 1 commit into from
Closed

Conversation

srishtig2412
Copy link

@srishtig2412 srishtig2412 commented Mar 19, 2023

I have added a link that will lead to a login/sign in page. These changes includes a sign-in and sign-up forms which will show up by selecting the respective buttons.

@kshitijrajsharma
Copy link
Member

Hi thanks for PR , can you add details about what PR does , it is always a good practice to describe your PR

@srishtig2412
Copy link
Author

Sure, I will add the details

@kshitijrajsharma kshitijrajsharma added Needs Review Means , This needs review from someone component : frontend labels Mar 23, 2023
Copy link
Member

@kshitijrajsharma kshitijrajsharma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good PR ! Thank you for your contribution ! Currently SignIN / SignUP Is being managed BY OSM Itself and not needed from fAIr Side ! It would be interesting to implement this , when we handle our own user base with extra fields . I am putting this PR on a hold for now !

@kshitijrajsharma kshitijrajsharma added on hold Waiting for Implementation and removed Needs Review Means , This needs review from someone labels Apr 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component : frontend on hold Waiting for Implementation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants