Add db parameter to split_by_square after recent changes to fmtm-splitter #2020
+3
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
bug
spwoodcock
reviewed
Dec 23, 2024
src/backend/tests/conftest.py
Outdated
| @@ -230,6 +230,7 @@ async def task_event(db, project, tasks, admin_user): | |||
| new_event = TaskEventIn( | |||
| task_id=task.id, | |||
| user_id=user.id, | |||
| username=user.username, | |||
There was a problem hiding this comment.
I'm surprised this isn't calculated in the SQL, using the user id?
If you insert both the user id and username, then it opens the potential for inconsistency: inserting a username that does not match the user id
There was a problem hiding this comment.
Ah you are right , I got what you meant to say. I was trying to solve the test case failure issue, but it seems to have github action issue?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this? (check all applicable)
Related Issue
Describe this PR
After a recent upgrade of split by square in the fmtm-splitter, it now requires an extra db parameter as a unicode string of db url, which fixes the mentioned issue.
Screenshots
N/A
Checklist before requesting a review
[optional] What gif best describes this PR or how it makes you feel?