Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

create a table to store bad and new geoms #2046

Merged
merged 2 commits into from
Jan 2, 2025
Merged

Conversation

Sujanadh
Copy link
Collaborator

What type of PR is this? (check all applicable)

  • πŸ• Feature
  • πŸ› Bug Fix
  • πŸ“ Documentation
  • πŸ§‘β€πŸ’» Refactor
  • βœ… Test
  • πŸ€– Build or CI
  • ❓ Other (please specify)

Related Issue

Describe this PR

This PR creates a table to store geometry with status 'BAD' or 'NEW'.

Response

{
  "geom": {
    "type": "Polygon",
    "coordinates": [
      [
        [
          85.333952,
          27.699157
        ],
        [
          85.333892,
          27.699038
        ],
        [
          85.33404,
          27.699001
        ],
        [
          85.334109,
          27.699095
        ],
        [
          85.333952,
          27.699157
        ]
      ]
    ]
  },
  "status": "NEW",
  "project_id": 3,
  "task_id": 1
}

Endpoint:

/projects/{project_id}/geometries

Alternative Approaches Considered

Did you attempt any other approaches that are not documented in code?

Review Guide

Notes for the reviewer. How to test this change?

Checklist before requesting a review

[optional] What gif best describes this PR or how it makes you feel?

@Sujanadh Sujanadh requested a review from spwoodcock December 31, 2024 10:13
@Sujanadh Sujanadh self-assigned this Dec 31, 2024
@github-actions github-actions bot added enhancement New feature or request backend Related to backend code migration Contains a DB migration labels Dec 31, 2024

BEGIN;

CREATE TABLE geometrylog (
Copy link
Member

@spwoodcock spwoodcock Dec 31, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work πŸ‘

Don't forget the db init script though =)
(So the table exists on a new FMTM instance without migrations)

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh yeah. okay πŸ‘

@Sujanadh Sujanadh merged commit d05d4c3 into development Jan 2, 2025
5 checks passed
@Sujanadh Sujanadh deleted the feat/new-geom-table branch January 2, 2025 04:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backend Related to backend code enhancement New feature or request migration Contains a DB migration
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants