Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

- Refactor test_basemap.py and add additional boundary handler tests #280

Merged
merged 7 commits into from
Aug 19, 2024
Merged

- Refactor test_basemap.py and add additional boundary handler tests #280

merged 7 commits into from
Aug 19, 2024

Commits on Aug 19, 2024

  1. - Introduced setup_boundary fixture for test 

    setup.
- Added GeoJSON boundary setup and included
BytesIO.
- Expanded `test_create` to include tile
generation for levels 8 to 12.
- Enhanced PMTile validation with specific zoom
 level assertion.
- Removed `test_init_with_bytesio` in
`TestBoundaryHandlerFactory` due to an
 AttributeError.
- Added tests for bounding box creation in
`BytesIOBoundaryHandler` and
`StringBoundaryHandler` classes.
- Included validation tests for invalid and empty
 boundary strings.
- Updated test methods to improve clarity and
coverage.
    @RonaldRonnie @spwoodcock
    RonaldRonnie authored and spwoodcock committed Aug 19, 2024
    Configuration menu
    Copy the full SHA
    a5143ff View commit details
    Browse the repository at this point in the history

  2. Update test_basemap.py 

    This update has been made to remove the useless / unnecessary code tests
    @RonaldRonnie @spwoodcock
    RonaldRonnie authored and spwoodcock committed Aug 19, 2024
    Configuration menu
    Copy the full SHA
    09d2a6c View commit details
    Browse the repository at this point in the history

  3. Update test_basemap.py 

    This update (fix) address and has been made to after removing the unwanted /useless or unnecessary tests from the PR
    @RonaldRonnie @spwoodcock
    RonaldRonnie authored and spwoodcock committed Aug 19, 2024
    Configuration menu
    Copy the full SHA
    958888d View commit details
    Browse the repository at this point in the history

  4. Delete tests/testdata/test.csv

    @RonaldRonnie @spwoodcock
    RonaldRonnie authored and spwoodcock committed Aug 19, 2024
    Configuration menu
    Copy the full SHA
    68cf603 View commit details
    Browse the repository at this point in the history

  5. test: fix osm output test (--> xml file)

    @spwoodcock
    spwoodcock committed Aug 19, 2024
    Configuration menu
    Copy the full SHA
    3ba4bbb View commit details
    Browse the repository at this point in the history

  6. ci: remove dup .xml from gitignore

    @spwoodcock
    spwoodcock committed Aug 19, 2024
    Configuration menu
    Copy the full SHA
    2b3a274 View commit details
    Browse the repository at this point in the history

  7. [pre-commit.ci] auto fixes from pre-commit.com hooks 

    for more information, see https://pre-commit.ci
    @pre-commit-ci
    pre-commit-ci[bot] committed Aug 19, 2024
    Configuration menu
    Copy the full SHA
    d402388 View commit details
    Browse the repository at this point in the history