Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Import file of usernames to provide private project access #773

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

ethan-nelson
Copy link
Collaborator

Fixes #760 by providing an interface to upload a file of usernames and give them access for private projects. The file can be comma separated, line separated, or a mixture of those. This doesn't add new users to the TM database, however. If a username supplied is not in the TM system, it will throw a 500 error for that name (shows up in console.log) and continue.

My javascripting probably isn't the neatest, so feedback is especially welcome on that. Tests are incoming.

Before
File to import
After (with erroneous name)

@coveralls
Copy link

Coverage Status

Coverage remained the same at 94.821% when pulling 04d065e on ethan-nelson:add-users-by-file into 034a65b on hotosm:master.

@ethan-nelson ethan-nelson changed the title [WIP] Import file of usernames to provide private project access Import file of usernames to provide private project access Apr 22, 2016
@ethan-nelson
Copy link
Collaborator Author

Since this is a javascript implementation, I wasn't able to figure out a way to write it into automated tests. Someone else will need to test it out on their machine to make sure it's 🆗

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants