-
Notifications
You must be signed in to change notification settings - Fork 34
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Dev Version : Stable #182
Merged
Merged
Dev Version : Stable #182
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
kshitijrajsharma
commented
Dec 21, 2023
- Launches Dev version : Stable
Enhance/query
Add storage account (blob store) in order to shunt large database backup files to Azure from AWS.
Add a storage account to resource group
- Allow public network access to Azure Key Vault inorder to allow Terraform Worker IP.
Add public network access to Key Vault
Add unique Storage Account name
Add systemd unit files for API, backend and worker services. Care has been taken to add security options without compromising program functions. Unit files check for the existence of env files needed for the programs
We need some way of managing server configurations, policy assurances, and a way to maintain state and detect drifts in configuration. Terraform has proved cumbersome to use for this purpose due to the complexity involved. Ansible is a better choice and does not require any agents and is idempotent (to an extent). Drifts can be checked without applying changes. Ansible is also easy to learn and understand; it use YAML playbooks which devs and DevOps understand with practice managing CI configurations. Organisation of the file hierarchy is pending. Inventory files won't be commited to the SCM and will be maintained centrally somewhere in a private repository accessible by devs and devops.
Add systemd unit files for raw-data services
Add inital ansible config management files
Enhance Boundaries
Use ansible to setup systemd services, reverse proxy, and dependencies. - Setup systemd service files for raw-data API, Worker and Backend - Add associated env files for systemd along with basic sanity checks - Setup Caddy server as a reverse proxy along with appropriate configuration. - Parameterise variables - Consolidate multiple similar resources using loops
Improve ansible scripts to cover more ground
Quick Fix : Name missing from countries
Template modules don't support using templates in the managed node. So switching to using local template as source.
Infra/ansible config management
Adjust conditions and env files
- Worker and API systemd files do not require EnvironmentFile option. So removed it. - Added a systemd daemon_reload action in Ansible to reread config after changes to systemd unit files
Remove systemd assertions
- Standardise the Virtualenv path to ${PROJECT_DIR}/.virtualenv to make it uniform between backend and API service - Dev confirms that there are no conflicting versions of dependencies between backend and API - Adjust systemd unit files to reflect the change
Fix virtualenv path for backend and API
Dump export metadata to .zip file
Feature : Dynamic Folder Upload
Bug - Fix : Fixes Leaked Connection
Enhance Bind Zip and updated Permission
Feature : Sozip
Feature : Polygon Stats Including Data Completeness Metrics
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
checkov found more than 20 potential problems in the proposed changes. Check the Files changed tab for more details.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.