Implemented: functionality to product store card on facility details page (#10) #14
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ymaheshwari1
requested changes
Nov 17, 2023
src/components/OpenStorePopover.vue
Outdated
| import { mapGetters, useStore } from "vuex"; | ||
| import { FacilityService } from "@/services/FacilityService"; | ||
| import { DateTime } from "luxon"; | ||
| import { hasError } from "@hotwax/oms-api"; |
There was a problem hiding this comment.
Import from adapter instead of importing from oms-api
src/components/OpenStorePopover.vue
Outdated
| import { FacilityService } from "@/services/FacilityService"; | ||
| import { DateTime } from "luxon"; | ||
| import { hasError } from "@hotwax/oms-api"; | ||
| import { showToast } from "@/utils"; | ||
|
|
||
| export default defineComponent({ | ||
| name: "OpenStorePopover", |
There was a problem hiding this comment.
Suggested change
| name: "OpenStorePopover", | |
| name: "ProductStorePopover", |
src/components/OpenStorePopover.vue
Outdated
| await this.store.dispatch('facility/getFacilityProductStores', { facilityId: this.facilityId }) | ||
| } | ||
| } catch(err) { | ||
| console.error(err) |
There was a problem hiding this comment.
Use logger instead of console.
src/components/OpenStorePopover.vue
Outdated
|
|
||
| // refetching product stores with updated roles | ||
| await this.store.dispatch('facility/getFacilityProductStores', { facilityId: this.facilityId }) | ||
| } |
There was a problem hiding this comment.
In case of error throw resp.data from else section.
| @@ -141,6 +141,33 @@ const actions: ActionTree<FacilityState, RootState> = { | |||
| facilityTypeId: '' | |||
| }) | |||
| commit(types.FACILITY_LIST_UPDATED , { facilities: [], total: 0 }); | |||
| }, | |||
|
|
|||
| async getFacilityProductStores({ commit, state }, params) { | |||
There was a problem hiding this comment.
Remove unused params.
| try { | ||
| const resp = await FacilityService.getFacilityProductStores(payload) | ||
|
|
||
| if (!hasError(resp) || resp.data.error === 'No record found') { |
There was a problem hiding this comment.
We don't need to check for exact error message explicitly, hasError method already checks for error in resp. Instead check for resp.data.count field.
| const resp = await FacilityService.getFacilityProductStores(payload) | ||
|
|
||
| if (!hasError(resp) || resp.data.error === 'No record found') { | ||
| productStores = resp.data.docs ? resp.data.docs : [] |
There was a problem hiding this comment.
No need to use ternary, as we will already check whether the resp has some data or not, using count param
| throw resp.data | ||
| } | ||
| } catch (error) { | ||
| console.error('Failed to fetch user associated product stores.', error) |
There was a problem hiding this comment.
Remove unwanted console statements
ymaheshwari1
requested changes
Nov 24, 2023
src/views/FacilityDetails.vue
Outdated
| @@ -140,27 +140,17 @@ | |||
| <ion-card-title> | |||
| {{ translate("Product Stores") }} | |||
| </ion-card-title> | |||
| <ion-button @click="addProductStore" fill="clear"> | |||
| <ion-button @click="selectProductStore()" fill="clear"> | |||
There was a problem hiding this comment.
Suggested change
| <ion-button @click="selectProductStore()" fill="clear"> | |
| <ion-button @click="selectProductStores()" fill="clear"> |
src/views/FacilityDetails.vue
Outdated
|
|
||
| const hasFailedResponse = [...updateResponses, ...createResponses].some((response: any) => response.status === 'rejected') | ||
| if(hasFailedResponse) { | ||
| showToast(translate('Failed to update some facility stores')) |
There was a problem hiding this comment.
Suggested change
| showToast(translate('Failed to update some facility stores')) | |
| showToast(translate('Failed to update product stores')) |
src/views/FacilityDetails.vue
Outdated
| this.removeProductFromPrimaryMember() | ||
| } | ||
| }) | ||
| showToast(translate('Facility stores updated successfully.')) |
There was a problem hiding this comment.
Suggested change
| showToast(translate('Facility stores updated successfully.')) | |
| showToast(translate('Product stores updated successfully.')) |
| "facilityId": this.facilityId, | ||
| "facilityGroupId": this.primaryMember.facilityGroupId, | ||
| "fromDate": this.primaryMember.fromDate, | ||
| "thruDate": DateTime.now().toMillis() |
There was a problem hiding this comment.
Handle case when having error in the resp.
ravilodhi
reviewed
Nov 27, 2023
| IonContent, | ||
| IonList, | ||
| IonListHeader, | ||
| IonIcon, |
There was a problem hiding this comment.
Arrange imports in alphabetical order.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related Issues
Closes #10
Short Description and Why It's Useful
Made product store card dynamic and functional on the facility details page.
Screenshots of Visual Changes before/after (If There Are Any)
Contribution and Currently Important Rules Acceptance