Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed: On find facility page the updated facility group will show & a toast will show on empty facility group name(#266) #270

Merged
merged 4 commits into from
Jul 18, 2024

Conversation

R-Sourabh
Copy link
Contributor

Related Issues

#266

Short Description and Why It's Useful

  • Previously, the facilityGroups were not updating correctly because the call was being made in the mounted lifecycle hook. Moving this call to the ionViewWillEnter ensures the data is refreshed each time the view is entered.
  • The delete functionality was not working properly. This was resolved by replacing the deleteFacilityGroup service with updateFacilityGroup, ensuring the deletion process is handled correctly.
  • A toast message was added to notify users when they attempt to submit an empty facility group name.

Contribution and Currently Important Rules Acceptance

src/components/FacilityGroupActionsPopover.vue Outdated Show resolved Hide resolved
src/components/FacilityGroupActionsPopover.vue Outdated Show resolved Hide resolved
@ymaheshwari1 ymaheshwari1 merged commit 478d441 into hotwax:main Jul 18, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants