Improved: Fixed code logic to prevent facilities list from becoming empty if the infinite scroll call fails(#282) #283
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… call is successful , if no result found user state is made empty and total count 0 , for unsuccessfl API callprevious state is set (hotwax#282)
… call is successful , if no result found user state is made empty and total count 0 , for unsuccessfl API callprevious state is set (hotwax#282)
Ridwan6947
changed the title
|
@Ridwan6947 Add related issue number. |
Ridwan6947
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related Issues
#282
Short Description and Why It's Useful
Made improvements to handle the state of facilities and ensured that facilities are correctly concatenated , if number of facilities are 0 , state is updated to empty list , else previous state is continued
Screenshots of Visual Changes before/after (If There Are Any)
Contribution and Currently Important Rules Acceptance