Implemented: UI for the facility details page and modals (#3) #6
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ymaheshwari1
requested changes
Nov 16, 2023
src/components/OpenStorePopover.vue
Outdated
Comment on lines
22
to
23
| IonItem, | ||
| IonIcon |
There was a problem hiding this comment.
Suggested change
| IonItem, | |
| IonIcon | |
| IonIcon, | |
| IonItem |
| }, | ||
| data() { | ||
| return { | ||
| isTimeModalOpen: false as boolean |
There was a problem hiding this comment.
Suggested change
| isTimeModalOpen: false as boolean | |
| isTimeModalOpen: false |
src/router/index.ts
Outdated
| @@ -46,6 +47,12 @@ const routes: Array<RouteRecordRaw> = [ | |||
| component: DxpLogin, | |||
| beforeEnter: loginGuard | |||
| }, | |||
| { | |||
| path: "/facility-details", | |||
There was a problem hiding this comment.
Suggested change
| path: "/facility-details", | |
| path: "/facility-details/:facilityId", | |
| props: true, |
ymaheshwari1
approved these changes
Nov 16, 2023
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related Issues
Closes #3
Short Description and Why It's Useful
Implemented UI for the facility details page
Screenshots of Visual Changes before/after (If There Are Any)
Contribution and Currently Important Rules Acceptance