Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implemented: Segment UI for facility details page (#4) #9

Merged
merged 9 commits into from
Nov 17, 2023
Merged

Implemented: Segment UI for facility details page (#4) #9

merged 9 commits into from
Nov 17, 2023

Conversation

amansinghbais
Copy link
Contributor

@amansinghbais amansinghbais commented Nov 16, 2023 •
edited
Loading

Related Issues

Closes #4

Short Description and Why It's Useful

Implemented UI for segment section of facility details page.

  • Created a segment selection tab and sections respectively.
  • Created modal for location, staff, and custom mapping.
  • Created popover for location details menu and add external mapping menu.
  • Updated the modal for operating time selector.

Screenshots of Visual Changes before/after (If There Are Any)

Screenshot from 2023-11-16 13-04-37

Screenshot from 2023-11-16 13-04-57

Screenshot from 2023-11-16 13-05-02

Screenshot from 2023-11-16 15-39-16

Screenshot from 2023-11-16 13-04-53

Screenshot from 2023-11-16 13-04-45

Screenshot from 2023-11-16 13-04-49

Screenshot from 2023-11-16 15-39-10

Contribution and Currently Important Rules Acceptance

@amansinghbais
Improved: code for segments on facility details page (hotwax#4)
2cb0668
@amansinghbais
Implemeneted: location details popover for location segment (hotwax#4)
4a9313f
@amansinghbais
Merge branch 'main' of https://github.com/hotwax/facilities into faci…
115f7ea 
…lities/hotwax#4
@amansinghbais
Implemented: modal for location, staff and customMapping, and externa…
0f71485 
…lSystem Popover (hotwax#4)
@amansinghbais
Improved: code for time selector, external mapping modal name and alp…
822354c 
…habetical ordering (hotwax#4)
@amansinghbais
Merge branch 'main' of https://github.com/hotwax/facilities into faci…
e32d038 
…lities/hotwax#4
@amansinghbais
Merge branch 'main' of https://github.com/hotwax/facilities into faci…
49f1079 
…lities/hotwax#4
@amansinghbais
Improved: main wrapping of all section removed (hotwax#4)
360a959
@amansinghbais
Merge branch 'main' of https://github.com/hotwax/facilities into faci…
b8d2a72 
…lities/hotwax#4
@ymaheshwari1 ymaheshwari1 merged commit dfc58d8 into hotwax:main Nov 17, 2023
1 check passed
@ravilodhi ravilodhi mentioned this pull request Aug 22, 2024
Merged
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Create segment UI for facility details page
2 participants
@amansinghbais @ymaheshwari1