Skip to content

Commit

Permalink
Improved: variable name for printing picklist(#176)
Browse files Browse the repository at this point in the history
  • Loading branch information
ymaheshwari1 committed Jul 12, 2023
1 parent 4c769b8 commit 572be43
Showing 1 changed file with 4 additions and 5 deletions.
9 changes: 4 additions & 5 deletions src/views/InProgress.vue
Original file line number Diff line number Diff line change
Expand Up @@ -27,7 +27,7 @@
{{ picklist.pickersName }}
<p>{{ picklist.date }}</p>
</ion-label>
<ion-spinner color="primary" slot="end" v-if="picklist.isGeneratingDocument" name="crescent" />
<ion-spinner color="primary" slot="end" v-if="picklist.isGeneratingPicklist" name="crescent" />
<ion-button v-else fill="outline" slot="end" @click="printPicklist(picklist)">
<ion-icon :icon="printOutline" />
</ion-button>
Expand Down Expand Up @@ -254,7 +254,6 @@ export default defineComponent({
picklists: [] as any,
defaultShipmentBoxType: '',
itemsIssueSegmentSelected: [] as any,
isGeneratingDocument: false as boolean
}
},
methods: {
Expand Down Expand Up @@ -622,7 +621,7 @@ export default defineComponent({
id: picklist.picklistId,
pickersName: pickersName.join(', '),
date: DateTime.fromMillis(picklist.picklistDate).toLocaleString(DateTime.TIME_SIMPLE),
isGeneratingDocument: false // used to display the spinner on the button when trying to generate picklist
isGeneratingPicklist: false // used to display the spinner on the button when trying to generate picklist
})
return picklists
Expand Down Expand Up @@ -764,9 +763,9 @@ export default defineComponent({
await this.updateOrderQuery(process.env.VUE_APP_VIEW_SIZE, '')
},
async printPicklist(picklist: any) {
picklist.isGeneratingDocument = true;
picklist.isGeneratingPicklist = true;
await OrderService.printPicklist(picklist.id)
picklist.isGeneratingDocument = false;
picklist.isGeneratingPicklist = false;
}
},
async mounted () {
Expand Down

0 comments on commit 572be43

Please sign in to comment.