Improved: added permission over the force scan setting (#664)

hotwax · Aug 5, 2024 · 7f54ae5 · 7f54ae5
1 parent 13a355c
commit 7f54ae5
Show file tree

Hide file tree

Showing 4 changed files with 8 additions and 6 deletions.
diff --git a/src/authorization/Actions.ts b/src/authorization/Actions.ts
@@ -9,5 +9,6 @@ export default {
     "APP_TRANSFER_ORDER_UPDATE":"APP_TRANSFER_ORDER_UPDATE",
     "APP_CARRIERS_VIEW" : "APP_CARRIERS_VIEW",
     "APP_CARRIERS_CREATE" : "APP_CARRIERS_CREATE",
-    "APP_ORDER_LOOKUP_VIEW": "APP_ORDER_LOOKUP_VIEW"
+    "APP_ORDER_LOOKUP_VIEW": "APP_ORDER_LOOKUP_VIEW",
+    "APP_UPDT_FULFILL_FORCE_SCAN_CONFIG": "APP_UPDT_FULFILL_FORCE_SCAN_CONFIG",
 }
diff --git a/src/authorization/Rules.ts b/src/authorization/Rules.ts
@@ -18,5 +18,6 @@ export default {
     "APP_TRANSFER_ORDER_UPDATE": "ORD_TRANSFER_ORDER_CREATE OR ORD_TRANSFER_ORDER_ADMIN",
     "APP_CARRIERS_VIEW": "CARRIER_SETUP_VIEW",
     "APP_CARRIERS_CREATE": "CARRIER_SETUP_VIEW",
-    "APP_ORDER_LOOKUP_VIEW": "FF_ORDER_LOOKUP_VIEW"
+    "APP_ORDER_LOOKUP_VIEW": "FF_ORDER_LOOKUP_VIEW",
+    "APP_UPDT_FULFILL_FORCE_SCAN_CONFIG": "COMMON_ADMIN"
 } as any
diff --git a/src/store/modules/util/actions.ts b/src/store/modules/util/actions.ts
@@ -480,7 +480,7 @@ const actions: ActionTree<UtilState, RootState> = {
     try {
       const resp = await UtilService.getProductStoreSetting(payload) as any
       if(!hasError(resp)) {
-        const respValue = resp.data.docs[0].settingValue
+        const respValue = resp.data.docs[0].settingValue === "true"
         commit(types.UTIL_FORCE_SCAN_STATUS_UPDATED, respValue)
       } else {
         dispatch('createForceScanSetting');
@@ -498,7 +498,7 @@ const actions: ActionTree<UtilState, RootState> = {
       fromDate,
       "productStoreId": ecomStore.productStoreId,
       "settingTypeEnumId": "FULFILL_FORCE_SCAN",
-      "settingValue": false
+      "settingValue": "false"
     }
 
     try {
@@ -552,7 +552,7 @@ const actions: ActionTree<UtilState, RootState> = {
       "fromDate": fromDate,
       "productStoreId": eComStoreId,
       "settingTypeEnumId": "FULFILL_FORCE_SCAN",
-      "settingValue": value
+      "settingValue": `${value}`
     }
 
     try {

diff --git a/src/views/Settings.vue b/src/views/Settings.vue
@@ -166,7 +166,7 @@
           <ion-card-content>
             {{ translate("Control whether the store requires the force scan during order packing or not.") }}
           </ion-card-content>
-          <ion-item lines="none" >
+          <ion-item lines="none" :disabled="!hasPermission(Actions.APP_UPDT_FULFILL_FORCE_SCAN_CONFIG)">
             <ion-toggle label-placement="start" :checked="isForceScanEnabled" @click.prevent="updateForceScanStatus($event)">{{ translate("Require scan") }}</ion-toggle>
           </ion-item>
         </ion-card>