-
Notifications
You must be signed in to change notification settings - Fork 37
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implemented: support to fetch data dynamically and added support to add custom field in the download exim(#159) #206
Merged
Merged
Changes from all commits
Commits
Show all changes
8 commits
Select commit
Hold shift + click to select a range
2e84c14
Implemented: support to fetch the packed orders information from the …
ymaheshwari1 473841f
Implemented: support to add a custom field in the download section(#159)
ymaheshwari1 375b6ab
Fixed: a case to not display the empty key on the UI(#159)
ymaheshwari1 dee69fc
Added: logic to add the custom fields in the download csv(#159)
ymaheshwari1 3a083ba
Improved: logic to not allow adding empty value in the custom key(#159)
ymaheshwari1 a86c882
Added: static text in locales file(#159)
ymaheshwari1 1a0be02
Removed: unsued style from the modal component(#159)
ymaheshwari1 524413f
Added: a todo note and trimmed values before generating the csv(#159)
ymaheshwari1 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,102 @@ | ||
<template> | ||
<ion-header> | ||
<ion-toolbar> | ||
<ion-buttons slot="start"> | ||
<ion-button @click="closeModal"> | ||
<ion-icon slot="icon-only" :icon="closeOutline" /> | ||
</ion-button> | ||
</ion-buttons> | ||
<ion-title>{{ $t("Add custom field") }}</ion-title> | ||
</ion-toolbar> | ||
</ion-header> | ||
|
||
<ion-content> | ||
<ion-list> | ||
<ion-item lines="full"> | ||
<ion-label position="fixed">{{ $t("Key") }}</ion-label> | ||
<ion-input :placeholder="$t('Enter key')" name="key" v-model="key" id="key" type="text" required /> | ||
</ion-item> | ||
<ion-item> | ||
<ion-label position="fixed">{{ $t("Value") }}</ion-label> | ||
<ion-input :placeholder="$t('Enter value')" name="value" v-model="value" id="value" type="text" required /> | ||
</ion-item> | ||
</ion-list> | ||
|
||
<ion-fab @click="saveCustomField()" vertical="bottom" horizontal="end" slot="fixed"> | ||
<ion-fab-button> | ||
<ion-icon :icon="checkmarkDoneOutline" /> | ||
</ion-fab-button> | ||
</ion-fab> | ||
</ion-content> | ||
</template> | ||
|
||
<script lang="ts"> | ||
import { | ||
IonButtons, | ||
IonButton, | ||
IonContent, | ||
IonFab, | ||
IonFabButton, | ||
IonHeader, | ||
IonIcon, | ||
IonInput, | ||
IonItem, | ||
IonLabel, | ||
IonList, | ||
IonTitle, | ||
IonToolbar, | ||
modalController | ||
} from "@ionic/vue"; | ||
import { defineComponent } from "vue"; | ||
import { checkmarkDoneOutline, closeOutline } from "ionicons/icons"; | ||
import { useStore } from "vuex"; | ||
import { showToast } from "@/utils" | ||
import { translate } from "@/i18n"; | ||
|
||
export default defineComponent({ | ||
name: "CustomFieldModal", | ||
components: { | ||
IonButtons, | ||
IonButton, | ||
IonContent, | ||
IonFab, | ||
IonFabButton, | ||
IonHeader, | ||
IonIcon, | ||
IonInput, | ||
IonItem, | ||
IonLabel, | ||
IonList, | ||
IonTitle, | ||
IonToolbar, | ||
}, | ||
data() { | ||
return { | ||
key: '', | ||
value: '' | ||
} | ||
}, | ||
methods: { | ||
closeModal() { | ||
modalController.dismiss({ dismissed: true}); | ||
}, | ||
saveCustomField() { | ||
const fieldKey = this.key.trim(); | ||
if(!fieldKey) { | ||
showToast(translate('Please enter a valid key')) | ||
return; | ||
} | ||
modalController.dismiss({ dismissed: true, value: { key: fieldKey, value: this.value } }); | ||
} | ||
}, | ||
setup() { | ||
const store = useStore(); | ||
|
||
return { | ||
checkmarkDoneOutline, | ||
closeOutline, | ||
store | ||
}; | ||
}, | ||
}); | ||
</script> |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Add TODO note that timeout need to be set when the order size gets really large