-
Notifications
You must be signed in to change notification settings - Fork 37
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Display Shipping Label Generation Errors for the completed Orders #215
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…g label error data in order services and added a shipping label error button and login to completed view
ymaheshwari1
requested changes
Jul 25, 2023
sanskar345
changed the title
Display Shipping Label Generation Errors for the In completed Orders
Display Shipping Label Generation Errors for the completed Orders
Jul 25, 2023
…rror message in modal and changed locales file for the same
ymaheshwari1
requested changes
Jul 31, 2023
…n order services and functionality of shipment label error button only be displayed when we have shipment label image
@ymaheshwari1 Sir please review it again. |
ymaheshwari1
requested changes
Aug 11, 2023
… place of completed view
@ymaheshwari1 Sir changes are done as requested please review. |
ymaheshwari1
requested changes
Aug 14, 2023
…rvice and changed gatewayMessage var to shipmentLabelErrorMessages
ymaheshwari1
approved these changes
Aug 14, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related Issues
Closes #190
Short Description and Why It's Useful
Implemented shipping label Modal to show shipping label error on click of Shipping Label Error button in completed orders.
Screenshots of Visual Changes before/after (If There Are Any)
IMPORTANT NOTICE - Remember to add changelog entry
Contribution and Currently Important Rules Acceptance