Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Display Shipping Label Generation Errors for the completed Orders #215

Merged
merged 14 commits into from
Aug 14, 2023

Conversation

sanskar345
Copy link
Contributor

@sanskar345 sanskar345 commented Jul 25, 2023

Related Issues

Closes #190

Short Description and Why It's Useful

Implemented shipping label Modal to show shipping label error on click of Shipping Label Error button in completed orders.

Screenshots of Visual Changes before/after (If There Are Any)

190 a

rer

IMPORTANT NOTICE - Remember to add changelog entry

Contribution and Currently Important Rules Acceptance

src/services/OrderService.ts Outdated Show resolved Hide resolved
src/services/OrderService.ts Outdated Show resolved Hide resolved
src/services/OrderService.ts Outdated Show resolved Hide resolved
src/store/modules/user/actions.ts Outdated Show resolved Hide resolved
src/views/Completed.vue Outdated Show resolved Hide resolved
src/views/Completed.vue Outdated Show resolved Hide resolved
@sanskar345 sanskar345 changed the title Display Shipping Label Generation Errors for the In completed Orders Display Shipping Label Generation Errors for the completed Orders Jul 25, 2023
src/services/OrderService.ts Show resolved Hide resolved
src/views/Completed.vue Outdated Show resolved Hide resolved
…n order services and functionality of shipment label error button only be displayed when we have shipment label image
@sanskar345
Copy link
Contributor Author

@ymaheshwari1 Sir please review it again.

@sanskar345
Copy link
Contributor Author

@ymaheshwari1 Sir changes are done as requested please review.

src/services/OrderService.ts Outdated Show resolved Hide resolved
src/services/OrderService.ts Outdated Show resolved Hide resolved
…rvice and changed gatewayMessage var to shipmentLabelErrorMessages
@ravilodhi ravilodhi merged commit 3107472 into hotwax:main Aug 14, 2023
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Display Shipping Label Generation Errors for the In progress Orders
3 participants