-
Notifications
You must be signed in to change notification settings - Fork 37
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improved: seperated partyname from util module by creating party module(#121) #401
base: main
Are you sure you want to change the base?
Conversation
src/store/RootState.ts
Outdated
@@ -5,5 +5,5 @@ export default interface RootState { | |||
user: any; | |||
product: any; | |||
util: UtilState; | |||
order: OrderState; | |||
order: OrderState |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Remove any unwanted change in the state
src/store/modules/party/actions.ts
Outdated
|
||
const actions: ActionTree<partyState, RootState> = { | ||
async fetchPartyInformation({ commit, state }, partyIds) { | ||
let partyInformation = JSON.parse(JSON.stringify(state.partyNames)) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Improve indentation in all the places.
src/services/PartyService.ts
Outdated
import { api } from '@/adapter'; | ||
|
||
const fetchPartyInformation = async (query: any): Promise <any> => { | ||
return api({ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Improve indentation.
Related Issues
Closes #121
Short Description and Why It's Useful
Screenshots of Visual Changes before/after (If There Are Any)
IMPORTANT NOTICE - Remember to add changelog entry
Contribution and Currently Important Rules Acceptance