Skip to content

Commit

Permalink
Merge pull request #290 from R-Sourabh/#289-externalFacilityId-change
Browse files Browse the repository at this point in the history
Improved: Replace externalFacilityId with facilityId in payload & increase the viewSize to 250 (#289)
  • Loading branch information
ymaheshwari1 authored Jul 17, 2024
2 parents 317c525 + 2106cdd commit c83e525
Show file tree
Hide file tree
Showing 3 changed files with 4 additions and 4 deletions.
2 changes: 1 addition & 1 deletion src/store/modules/util/actions.ts
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,7 @@ const actions: ActionTree<UtilState, RootState> = {
"facilityTypeId_op": "notEqual",
},
"fieldList": ["facilityId", "facilityName", "parentTypeId", "externalId"],
"viewSize": 50,
"viewSize": 250,
"entityName": "FacilityAndType",
"noConditionFind": "Y"
}
Expand Down
2 changes: 1 addition & 1 deletion src/views/ScheduledRestock.vue
Original file line number Diff line number Diff line change
Expand Up @@ -70,7 +70,7 @@
</ion-item>
<ion-item>
<ion-select :label="translate('Facility')" interface="popover" :placeholder = "translate('Select')" v-model="selectedFacility">
<ion-select-option v-for="facility in facilities" :key="facility.facilityId" :value="facility.externalId">
<ion-select-option v-for="facility in facilities" :key="facility.facilityId" :value="facility.facilityId">
{{ facility.facilityName || facility.facilityId }}
</ion-select-option>
</ion-select>
Expand Down
4 changes: 2 additions & 2 deletions src/views/ScheduledRestockReview.vue
Original file line number Diff line number Diff line change
Expand Up @@ -41,7 +41,7 @@
<ion-item>
<ion-icon slot="start" :icon="businessOutline"/>
<ion-select :label="translate('Facility')" interface="popover" :placeholder = "translate('Select')" v-model="schedule.facilityId">
<ion-select-option v-for="facility in facilities" :key="facility.facilityId" :value="facility.externalId">
<ion-select-option v-for="facility in facilities" :key="facility.facilityId" :value="facility.facilityId">
{{ facility.facilityName || facility.facilityId }}
</ion-select-option>
</ion-select>
Expand Down Expand Up @@ -244,7 +244,7 @@ export default defineComponent({
const uploadData = {
payload: {
externalDestinationFacilityId: destinationFacilityId,
destinationFacilityId: destinationFacilityId,
items: items
}
};
Expand Down

0 comments on commit c83e525

Please sign in to comment.