Implemented: Updated the DataManager Logs page to be dynamic in Job Manager(#680) #729
Conversation
| <template> | ||
| <ion-content> | ||
| <ion-list> | ||
| <ion-list-header>{{ translate('Log Id') }}</ion-list-header> |
There was a problem hiding this comment.
This will the data manager log ID not the text "Log Id".
| <ion-item button @click="downloadLogFile('logFile')"> | ||
| {{ translate('Log file') }} | ||
| </ion-item> | ||
| <ion-item button :lines="log?.errorRecordContentId ? undefined : 'none'" @click="downloadLogFile('uploadedFle')"> |
There was a problem hiding this comment.
I think we should show error item disabled instead of hiding, if there is not error content.
| let dataResource = {} as any; | ||
|
|
||
| if (type === 'logFile') { | ||
| contentIdType = 'logFileContentId'; |
There was a problem hiding this comment.
Rename contentIdType to contentId and fetch the contentId in the if/else block itself.
src/store/modules/job/actions.ts
Outdated
| let logs = [] as any | ||
| const payload = { | ||
| "inputFields": { | ||
| "statusId": ["SERVICE_CANCELLED", "SERVICE_CRASHED", "SERVICE_FAILED", "SERVICE_FINISHED", "SERVICE_PENDING", "SERVICE_RUNNING", "SERVICE_QUEUED"], |
There was a problem hiding this comment.
No need to apply any filter on status.
src/store/modules/job/actions.ts
Outdated
| }).catch((err: any) => { | ||
| logger.error(err); | ||
| }) | ||
| commit(types.JOB_DATA_RESOURCE_IDS_UPDATED, dataResourceIds); |
There was a problem hiding this comment.
Instead of storing dataResourceIds separately, I think you should add the needed field in the respective data manager config record itself.
src/store/modules/job/actions.ts
Outdated
| commit(types.JOB_DATA_RESOURCE_IDS_UPDATED, dataResourceIds); | ||
| }, | ||
|
|
||
| async fetchDataManagerConfig({ commit }, params) { |
There was a problem hiding this comment.
As we are not storing anything to state here, we can skip using action here. Service itself should fulfil the purpose.
|
|
||
| if (dataResource) { | ||
| try { | ||
| const response = await JobService.downloadCsv({ |
There was a problem hiding this comment.
Rename this service name to something like fetchFileData.
src/components/ImportLogsDetail.vue
Outdated
| </div> | ||
|
|
||
| <div class="ion-padding"> | ||
| <ion-chip v-for="(chip, index) in chips" :key="index" outline @click="updateLogs(chip.label)"> |
There was a problem hiding this comment.
The list name should be logFilters or dataManagerLogFilters instead of chips.
src/components/ImportLogsDetail.vue
Outdated
| </div> | ||
|
|
||
| <div class="ion-padding"> | ||
| <ion-chip v-for="(chip, index) in chips" :key="index" outline @click="updateLogs(chip.label)"> |
There was a problem hiding this comment.
The updateLogs should also be rename to something filterLogs or filterDataManagerLogs.
src/components/ImportLogsDetail.vue
Outdated
| <p>{{ translate('Finished') }}</p> | ||
| </ion-label> | ||
|
|
||
| <ion-badge color="success" v-if="log.statusId === 'SERVICE_FINISHED'">{{ translate('Finished') }}</ion-badge> |
There was a problem hiding this comment.
Display the status description here. You need to fetch the status data for statusTypeId='SERVICE_STATUS' and then create uiLables for all the statuses.
src/components/ImportLogsDetail.vue
Outdated
| return { | ||
| configDetails: {}, | ||
| selectedChip: 'All', | ||
| chips: [ |
There was a problem hiding this comment.
This should be renamed to logFilters and it should be the array of object, each filter object with key and value. So that when apply filters you can pass the ID.
…e text refactor job actions(hotwax#680)
… and made changes in the css(hotwax#680)
| } | ||
|
|
||
| .config { | ||
| .config-details { | ||
| align-self: end; |
There was a problem hiding this comment.
I don't think this is needed. The content should instead expand to fill the remaining space. both grid columns should take equal space. The Width of the grid should be restricted to control the width of its children.
There was a problem hiding this comment.
The align-self property is aligning the grid column to the end vertically, not horizontally, as the layout suggests. I used this property to position the configuration name section at the bottom vertically as mentioned in the figma. After removing it, this is how it looks:
There was a problem hiding this comment.
makes sense, I mixed up justify and align. Thanks for clarifying. It was correct the way you had it
Related Issues
#680
Short Description and Why It's Useful
Screenshots of Visual Changes before/after (If There Are Any)
Contribution and Currently Important Rules Acceptance