Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed: timeZone does not gets updated for user login, removed confirm alert, and added loading state #280

Merged
merged 7 commits into from
Feb 21, 2024

Conversation

amansinghbais
Copy link
Contributor

Related Issues

When changing the timeZone, the timeZone gets updated in the app untill logout, but after logout and login the user timeZone is again set to the previous state.

Short Description and Why It's Useful

  • Updated api payload to pass the correct param for timeZoneId so to set the timeZone for the user
  • Removed confirm alert before updating the timeZone
  • Enabled timeZone updation on enter
  • Handled case to show loading state untill we does not get the timeZones list

Screenshots of Visual Changes before/after (If There Are Any)

IMPORTANT NOTICE - Remember to add changelog entry

Contribution and Currently Important Rules Acceptance

src/views/TimezoneModal.vue Outdated Show resolved Hide resolved
src/locales/en.json Outdated Show resolved Hide resolved
@ravilodhi ravilodhi merged commit 1871778 into hotwax:main Feb 21, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants